sys/mod doc update and mod import order adjust #39844

king6cong · 2017-02-15T10:53:13Z

Some doc updates.
Racer currently use the first mod it finds regardless of cfg attrs. Moving #[cfg(unix)] up should be a temporary tweak that works as expected for more people.

rust-highfive · 2017-02-15T10:53:25Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2017-02-15T14:48:59Z

@bors: r+ rollup

bors · 2017-02-15T14:49:00Z

📌 Commit b821313 has been approved by alexcrichton

sys/mod doc update and mod import order adjust * Some doc updates. * Racer currently use the first mod it finds regardless of cfg attrs. Moving #[cfg(unix)] up should be a temporary tweak that works as expected for more people.

Rollup of 11 pull requests - Successful merges: #39775, #39793, #39804, #39824, #39834, #39837, #39839, #39840, #39843, #39844, #39846 - Failed merges:

sys/mod doc update and mod import order adjust * Some doc updates. * Racer currently use the first mod it finds regardless of cfg attrs. Moving #[cfg(unix)] up should be a temporary tweak that works as expected for more people.

Rollup of 12 pull requests - Successful merges: #39775, #39793, #39804, #39834, #39836, #39839, #39840, #39843, #39844, #39846, #39857, #39861 - Failed merges:

lilianmoraru · 2017-03-05T17:39:06Z

@king6cong @alexcrichton
Using #[cfg(target_os = "redox")] seems problematic to me.
You can have the host unix/windows and the target redox - shouldn't there be conflicts?
If this works for reasons I don't understand, than think of the build.rs "script".
A crate like tempdir(it's not the best example in the case of tmp, think setenv function), how does it decide which implementation of temp_dir() to use. It has to work in build.rs and also in an application that runs in redox.

Edit: In the case of build.rs I think I confused things. It will be built 2 times, for host(for build.rs) and then again for the binary/library.

Edit2: Now seems to me that the other 2 are incorrect.
Shouldn't it be target_os for all? What if you cross-compile?
Did anyone try to cross-compile to unix targets from Windows?
It seems to me you should not be able to cross-compile from Windows to emscripten as an example.

alexcrichton · 2017-03-06T16:28:45Z

@lilianmoraru oh it may make sense if I say that unix/windows/redox are all mutually exclusive, so only one of these modules ever exists.

lilianmoraru · 2017-03-06T17:44:45Z

I confused cfg ([os]) meaning cfg(host_os) instead of cfg (target_family)

sys/mod doc update and mod import order adjust

b821313

rust-highfive assigned alexcrichton Feb 15, 2017

frewsxcv mentioned this pull request Feb 15, 2017

Rollup of 11 pull requests #39863

Closed

bors added a commit that referenced this pull request Feb 16, 2017

Auto merge of #39863 - frewsxcv:rollup, r=frewsxcv

b942cd4

Rollup of 11 pull requests - Successful merges: #39775, #39793, #39804, #39824, #39834, #39837, #39839, #39840, #39843, #39844, #39846 - Failed merges:

frewsxcv mentioned this pull request Feb 16, 2017

Rollup of 12 pull requests #39869

Closed

frewsxcv mentioned this pull request Feb 16, 2017

Rollup of 12 pull requests #39876

Merged

bors added a commit that referenced this pull request Feb 16, 2017

Auto merge of #39876 - frewsxcv:rollup, r=frewsxcv

d77af7f

Rollup of 12 pull requests - Successful merges: #39775, #39793, #39804, #39834, #39836, #39839, #39840, #39843, #39844, #39846, #39857, #39861 - Failed merges:

bors merged commit b821313 into rust-lang:master Feb 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sys/mod doc update and mod import order adjust #39844

sys/mod doc update and mod import order adjust #39844

king6cong commented Feb 15, 2017

rust-highfive commented Feb 15, 2017

alexcrichton commented Feb 15, 2017

bors commented Feb 15, 2017

lilianmoraru commented Mar 5, 2017 •

edited

Loading

alexcrichton commented Mar 6, 2017

lilianmoraru commented Mar 6, 2017

sys/mod doc update and mod import order adjust #39844

sys/mod doc update and mod import order adjust #39844

Conversation

king6cong commented Feb 15, 2017

rust-highfive commented Feb 15, 2017

alexcrichton commented Feb 15, 2017

bors commented Feb 15, 2017

lilianmoraru commented Mar 5, 2017 • edited Loading

alexcrichton commented Mar 6, 2017

lilianmoraru commented Mar 6, 2017

lilianmoraru commented Mar 5, 2017 •

edited

Loading